[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 30 08:34:30 PDT 2022


svenvh created this revision.
svenvh added reviewers: Anastasia, stuart.
svenvh added a project: clang.
Herald added subscribers: Naghasan, ldrumm, yaxunl.
Herald added a project: All.
svenvh requested review of this revision.
Herald added a subscriber: cfe-commits.

For newer OpenCL extensions that do not require a pragma, such as
`cl_khr_subgroup_shuffle`, a user could still accidentally attempt to
use a pragma.  This would result in a warning

  "unknown OpenCL extension 'cl_khr_subgroup_shuffle' - ignoring"

which could be mistakenly interpreted as "Clang does not support this
extension at all" instead of "Clang does not require any pragma for
this extension".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126660

Files:
  clang/include/clang/Basic/DiagnosticParseKinds.td
  clang/test/Headers/opencl-c-header.cl
  clang/test/Parser/opencl-pragma.cl
  clang/test/SemaOpenCL/extension-begin.cl
  clang/test/SemaOpenCL/extension-version.cl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126660.432935.patch
Type: text/x-patch
Size: 9593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220530/4c655b30/attachment.bin>


More information about the cfe-commits mailing list