[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat May 28 04:55:50 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a very minor nit that can be corrected when landing.
================
Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:143
isReferencedOutsideOfCallExpr(*Function, *Result.Context) ||
- isExplicitTemplateSpecialization(*Function))
+ (Function->getTemplatedKind() != FunctionDecl::TK_NonTemplate))
return;
----------------
No need for the extra parens.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116593/new/
https://reviews.llvm.org/D116593
More information about the cfe-commits
mailing list