[PATCH] D126412: Fix a buglet in remove_dots().

Paul Pluzhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 27 13:22:51 PDT 2022


ppluzhnikov created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
ppluzhnikov updated this revision to Diff 432324.
ppluzhnikov added a comment.
ppluzhnikov updated this revision to Diff 432461.
ppluzhnikov updated this revision to Diff 432551.
ppluzhnikov updated this revision to Diff 432577.
ppluzhnikov updated this revision to Diff 432592.
ppluzhnikov updated this revision to Diff 432612.
ppluzhnikov updated this revision to Diff 432623.
ppluzhnikov published this revision for review.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Fix failed tests.


ppluzhnikov added a comment.

Rebase to ToT.


ppluzhnikov added a comment.

Fix InMemoryFileSystemTest bug.


ppluzhnikov added a comment.

Fix ProxyFileSystemTest.Basic on Win/x64


ppluzhnikov added a comment.

One more ProxyFileSystemTest fixe.


ppluzhnikov added a comment.

Fix compile failure.


ppluzhnikov added a comment.

Fix formatting.


The function promises to canonicalize the path, but neglected to do so
for the root component.

For example, calling remove_dots("/tmp/foo.c", Style::windows_backslash)
resulted in "/tmp\foo.c". Now it produces "\tmp\foo.c".

Also fix FIXME in the corresponding test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126412

Files:
  clang/unittests/Basic/FileManagerTest.cpp
  clang/unittests/Frontend/PCHPreambleTest.cpp
  llvm/lib/Support/Path.cpp
  llvm/unittests/Support/Path.cpp
  llvm/unittests/Support/VirtualFileSystemTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126412.432623.patch
Type: text/x-patch
Size: 5375 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220527/f2445f25/attachment-0001.bin>


More information about the cfe-commits mailing list