[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 27 11:43:51 PDT 2022


nridge added a comment.

Haven't had a chance to try it yet, but based on a quick glance, my suspicion is that the problem is the use of `ReferenceType::getPointeeType()`, which may do more unwrapping than we want (its implementation contains a loop <https://searchfox.org/llvm/rev/a94d454390c6c351cea64cff4d4229df16d01217/clang/include/clang/AST/Type.h#2785>).

I would try using getPointeeTypeAsWritten() <https://searchfox.org/llvm/rev/a94d454390c6c351cea64cff4d4229df16d01217/clang/include/clang/AST/Type.h#2780> instead and see if that helps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124690/new/

https://reviews.llvm.org/D124690



More information about the cfe-commits mailing list