[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 27 06:46:42 PDT 2022


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

Nice. This is the patch that makes the condition obsolete: D60871 <https://reviews.llvm.org/D60871>. You might also remove the `else`, since the first `if` now has an unconditional early return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126524/new/

https://reviews.llvm.org/D126524



More information about the cfe-commits mailing list