[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:257
+    } else if (Scope != "none") {
+      D.Diag(diag::err_invalid_sls_hardening) << Scope << A->getAsString(Args);
+    }
----------------
nickdesaulniers wrote:
> MaskRay wrote:
> > The convention is `err_drv_unsupported_option_argument`. Don't add a new kind.
> Disagree. Look at https://reviews.llvm.org/D81404. It's not a new diagnostic; passing an unexpected value for the equals flag is precisely what err_invalid_sls_hardening is for.
Yeah, I think it's OK to use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126137/new/

https://reviews.llvm.org/D126137