[PATCH] D126192: [Driver] Support linking with lld for target AVR

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 26 17:47:39 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:530
+      if (AVRLibcRoot && FamilyName) {
+        std::string Prefix(*AVRLibcRoot + "/lib/ldscripts/");
+        if (llvm::sys::fs::is_directory(Prefix)) {
----------------
I am concerned with the magic here. Shouldn't you let users specify explicit -T?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126192/new/

https://reviews.llvm.org/D126192



More information about the cfe-commits mailing list