[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:368
 
-Select straight-line speculation hardening scope
+Select straight-line speculation hardening scope (AArch64/X86 only). <arg> must be 'all', 'none', 'retbr'(AArch64), 'blr'(AArch64), 'return'(X86), 'indirect-branch'(X86)
 
----------------
This file is generated occasionally. Please don't modify it.


================
Comment at: clang/test/Driver/x86-target-features.c:312
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mharden-sls=indirect-branch %s -### -o %t.o 2>&1 | FileCheck -check-prefix=SLS-IND %s
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mharden-sls=none -mharden-sls=all %s -### -o %t.o 2>&1 | FileCheck -check-prefix=SLS-ALL %s
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mharden-sls=all -mharden-sls=none %s -### -o %t.o 2>&1 | FileCheck -check-prefix=SLS-NONE %s
----------------
Since you have tested both `-mharden-sls=none -mharden-sls=all` and `-mharden-sls=all -mharden-sls=none`, single `none` and single `all` RUN lines can be deleted.

Try reducing the number of %clang RUN lines. They make testsuite slow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126137/new/

https://reviews.llvm.org/D126137