[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo
Renato Golin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 26 04:08:54 PDT 2022
rengolin added a comment.
This looks good to me, but wait to make sure others see it, too.
My reasons are: it is largely similar to RISCV implementation, it seems to follow what I expected of the ABI (which is similar to other targets) and has a large corpus of tests.
I can't comment on the specifics of the ABI implementation (I haven't read the ABI document *that* thoroughly), but as David said, issues will be picked up by tests until the target reaches maturity.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126451/new/
https://reviews.llvm.org/D126451
More information about the cfe-commits
mailing list