[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

[Balázs Benics via Phabricator via cfe-commits]

steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Typo; other than that LGTM



================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:118
+  // Make internal constraint solver entities friends so they can access the
+  // overconstrained related functions. We want to keep this API inaccessible
+  // for Checkers.
----------------



================
Comment at: clang/test/Analysis/runtime-regression.c:8
+// related to the assume machinery. This is an automatically reduced code. The
+// analysis should finish in less than 10 seconds.
+
----------------
martong wrote:
> steakhal wrote:
> > Maybe the test infra has something to specify a timeout.
> I could not find how to set a timeout in the test file. There is a lit cli option that might be used, however, that would affect all other test cases. https://llvm.org/docs/CommandGuide/lit.html#cmdoption-lit-timeout
Why you could do is to call `RUN {lit} --max-time XX` Then do a `FileCheck` against the output of that.
Alternatively, we can craft something to make the situation worse, to the point that we will notice, and effectively hang the test suite. Either way, I'm fine with how things look ATM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126406/new/

https://reviews.llvm.org/D126406