[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

Wed May 25 16:01:45 PDT 2022

probinson added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596
+      DefaultedSMFArePOD = false;
+  }
+
----------------
dblaikie wrote:
> probinson wrote:
> > Does this mean `-fclang-abi-compat` will override the PS4/Darwin special case?  I think we don't want to do that.
> I don't think so - this expression will make `DefaultedSMFArePOD` false when it's already false due to the target not being PS4 or Darwin, yeah? So it'll redundantly/harmlessly set it to false.
No, I mean if it *is* PS4, it will turn true into false, and that's bad.  If I'm reading this correctly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051