[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

I'm very happy with how this patch is looking.



================
Comment at: clang/include/clang/Sema/DeclSpec.h:1926-1928
+    assert(llvm::all_of(DeclarationAttrs, [](const ParsedAttr &AL) {
+      return AL.isStandardAttributeSyntax();
+    }));
----------------
rsmith wrote:
> I think I recall seeing OpenMP pragma attributes being parsed as declaration attributes too. FIXME update this comment after review is complete
Oops, forgot to circle back to this. I think I was wrong; please disregard :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126061/new/

https://reviews.llvm.org/D126061