[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 10:26:34 PDT 2022


dang added a comment.

In D125678#3517174 <https://reviews.llvm.org/D125678#3517174>, @zixuw wrote:

> In D125678#3517168 <https://reviews.llvm.org/D125678#3517168>, @QuietMisdreavus wrote:
>
>> clang-format failed:
>>
>>   ---  clang-format
>>   
>>   changed files:
>>   
>>       clang/test/ExtractAPI/underscored.c
>
> I think it's fine. clang-format always get tripped on split-file tests because of the mixed format and what not.

Yeah this always unfortunately happens can't expect clang format to seamlessly accept to format both C and JSON. Also formatting matters less in tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125678/new/

https://reviews.llvm.org/D125678



More information about the cfe-commits mailing list