[PATCH] D125814: Improve the strict prototype diagnostic behavior

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 09:26:48 PDT 2022


aaron.ballman added a comment.

In D125814#3535452 <https://reviews.llvm.org/D125814#3535452>, @jyknight wrote:

> Good improvement, but an additional change to wording for just the zero-arg non-prototype function declaration case could help a lot. The fact that zero-arg it's only being warned about because of the "...because of" note isn't particularly clear -- especially when the "because of" isn't emitted.
>
> So, suggestion for zero-arg-specific warning text:

Thanks for the suggestion! I've implemented something along these lines in this patch and I think the diagnostics are better this way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125814/new/

https://reviews.llvm.org/D125814



More information about the cfe-commits mailing list