[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 04:11:07 PDT 2022


curdeius added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874
 
-  if (SimpleBlock && !KeepBraces) {
+  auto RemoveBraces = [=]() mutable {
+    if (KeepBraces || !SimpleBlock)
----------------
Are there many captures here? Wouldn't it be better to be explicit and/or capture by ref? Do we need a mutable lambda?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126358/new/

https://reviews.llvm.org/D126358



More information about the cfe-commits mailing list