[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

Laurentiu Tertan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 17:19:20 PDT 2022


ltertan added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.cpp:455
+                                                   << "-maltivec";
+
+  // Cannot allow soft-float with Altivec.
----------------
Do we also need to return from here?


================
Comment at: clang/lib/Basic/Targets/PPC.cpp:461
+                                                   << "-mno-altivec";
+
   // vsx was not explicitly turned off.
----------------
Do we also need to return from here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126302/new/

https://reviews.llvm.org/D126302



More information about the cfe-commits mailing list