[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 14:14:04 PDT 2022


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983
+                          CurrentRegion != OMPD_loop &&
+                          !(SemaRef.getLangOpts().OpenMPExtensions &&
+                            CurrentRegion == OMPD_atomic);
----------------
jdenny wrote:
> ABataev wrote:
> > Can you add a check for 5.2?
> This is an extension relative not only to 5.2 and but also to previous versions.  I quoted 5.2 just because it's the most recent.
> 
> Given that, I'm not sure why this should check for 5.2.  Am I misunderstanding your request?
Just looks like it is allowed in 5.2. Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126323/new/

https://reviews.llvm.org/D126323



More information about the cfe-commits mailing list