[PATCH] D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 12:36:46 PDT 2022


ymandel added a comment.

In D126316#3535057 <https://reviews.llvm.org/D126316#3535057>, @tschuett wrote:

> or `min(MaxAverageVisitsPerBlock * BlockStates.size(), 2^16);`

Good idea, thx.

In D126316#3535077 <https://reviews.llvm.org/D126316#3535077>, @xazax.hun wrote:

> An alternative approach is to maintain separate counters for back edges and bail if those reach a certain limit. But this global limit is way simpler, so it looks good to me.

Agreed -- this seems a better approach. Added as a FIXME. We should revisit...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126316/new/

https://reviews.llvm.org/D126316



More information about the cfe-commits mailing list