[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 09:00:09 PDT 2022


yaxunl added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6845-6846
+    llvm::MD5::MD5Result Result;
+    for (const auto &Arg : PreprocessorOpts.Macros)
+      Hash.update(Arg.first);
+    Hash.final(Result);
----------------
Are these options always the same for device and host compilation?

If not, this may not work since host and device compilation will have different names for the same variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125904/new/

https://reviews.llvm.org/D125904



More information about the cfe-commits mailing list