[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

Anton Fedorov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 04:45:54 PDT 2022


datacompboy added a comment.

In D126077#3530189 <https://reviews.llvm.org/D126077#3530189>, @njames93 wrote:

> Do you know of any other instances where this issue could surface?

I didn't found any other cases where isDerivedFrom used directly, only in couple of internal checks, none of which are part of clang distribution.

> Please can you add a line to the `Improved Checks` section in `clang-tools-extra/docs/ReleaseNotes.rst` about this fix. Make sure it is in alphabetical order.

I removed test case from the clang-tidy and made a unit-test instead, so it's not affecting this section.
Do you think it worth to include in any other release notes sections?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126077/new/

https://reviews.llvm.org/D126077



More information about the cfe-commits mailing list