[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 03:28:38 PDT 2022


martong added a comment.

In D126123#3531150 <https://reviews.llvm.org/D126123#3531150>, @steakhal wrote:

> In D126123#3531112 <https://reviews.llvm.org/D126123#3531112>, @martong wrote:
>
>> Is it documented with `getRegion`?  Could we decorate that with `returns-nonnull` https://clang.llvm.org/docs/AttributeReference.html#returns-nonnull ?
>
> Ah, I thought one of my changes addressing this was already on review.
> It turns out it was not the case. Now I uploaded it for review: D126198 <https://reviews.llvm.org/D126198>

Ok, could you please change the title of this Differential Revision? Something is still not fitting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126123/new/

https://reviews.llvm.org/D126123



More information about the cfe-commits mailing list