[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

[Phoebe Wang via Phabricator via cfe-commits]

pengfei updated this revision to Diff 431607.
pengfei marked 5 inline comments as done.
pengfei added a comment.

Address @nickdesaulniers 's comments. Thanks for the thorough review and suggestions!

> So we pessimize tail calls. Please fix and add a test case for that. This might be an unintended side effect of using `isUnconditionalBranch`.

Done. The problem is tail calls have `isReturn = 1`, so we have to handle tail call specailly.

> The first seems to have some interaction between -fcf-protection and __builtin_eh_return. Is that something we need to handle?

I think we should have covered the case since we do it for all JMP and RET. However, the same option doesn't generate JMP at all on Clang. So I'm not sure of that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126137/new/

https://reviews.llvm.org/D126137

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/Driver/ToolChains/Arch/X86.cpp
  clang/test/Driver/x86-target-features.c
  llvm/lib/Target/X86/X86.td
  llvm/lib/Target/X86/X86AsmPrinter.cpp
  llvm/lib/Target/X86/X86AsmPrinter.h
  llvm/test/CodeGen/X86/speculation-hardening-sls.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126137.431607.patch
Type: text/x-patch
Size: 9222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220524/01c65906/attachment.bin>