[PATCH] D126224: Add DWARF string debug to clang release notes.

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D126224#3531949 <https://reviews.llvm.org/D126224#3531949>, @rnk wrote:

> I am reminded of the perennial problem of "optional" protobuf fields that, when omitted, will cause production crashes.
>
> Do you think it would be less disruptive to synthesize a name? I believe the string lives in a string pool, so naming all string literals `<stringliteral>` seems like it could be acceptable.

While the string would be deduplicated, the offset in the DIEs (or index in DWARFv5, plus offset in .debug_str_offsets) for each of these strings would not. But perhaps that would still be low-cost enough (if we were getting really fancy, we could bake that string offset/index into the abbreviation - though we probably don't have the infrastructure in LLVM's DWARF emission to do that super easily)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126224/new/

https://reviews.llvm.org/D126224