[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

Michiel Derhaeg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 23 14:15:20 PDT 2022


MichielDerhaeg marked an inline comment as done.
MichielDerhaeg added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762
     // reject options that shouldn't be supported in bitcode
     // also reject kernel/kext
     static const constexpr unsigned kBitcodeOptionIgnorelist[] = {
----------------
wanders wrote:
> This comment and variable name are not as accurate any longer.  Maybe moving it inside `if (RawTriple.isOSDarwin())` makes it clearer.
Changed the comment to what I could derive from {D61627}.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125974/new/

https://reviews.llvm.org/D125974



More information about the cfe-commits mailing list