[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 23 12:29:20 PDT 2022


jhuber6 added a comment.

In D126226#3532216 <https://reviews.llvm.org/D126226#3532216>, @tra wrote:

> You do not need to hardcode it. The idea of `JoinedAndSeparate` is that an option `foo` assepts two argumants, one glued to it and another following after a whitespace.
> So, when you define an option `-Xoffload-linker-`, and then pass `-Xoffload-linker-nvptx64=foo`, you will get `OPT_offload-linker__` with two arguments. As an example see implementation of `plugin_arg` which deals with the same kind of problem of passing arguments to an open-ended set of plugins.

I see, it's a little weird sinec the `-Xopenmp-target` option will be done different, but changing to this should just require switching out the `=` with `-`. I'll go ahead and do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126226/new/

https://reviews.llvm.org/D126226



More information about the cfe-commits mailing list