[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 23 06:16:28 PDT 2022


steakhal added inline comments.


================
Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233
+      : Kind(k), Ctx(ctx), Parent(parent), ID(ID) {
+    assert(Ctx);
+  }
----------------
martong wrote:
> To be consistent with the other hunks, where you assert on the parameter, not on the member.
It's totally messed up, there is absolutely no consistency regarding this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126198/new/

https://reviews.llvm.org/D126198



More information about the cfe-commits mailing list