[PATCH] D126192: [Driver] Support linking with lld for target AVR

[Ben Shi via Phabricator via cfe-commits]

benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461
             << CPU;
-      } else if (TC.getGCCInstallPath().empty()) {
-        // We can not link since there is no avr-ld.
----------------
This check is no longer needed, since we will check `if (!llvm::sys::fs::can_execute(FullPath))` at above lines.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:526
+      CmdArgs.push_back(Args.MakeArgString("__vectors"));
+      // We must explicitly spefify the linker script (for lld), which has
+      // already been integrated into avr-libc, and whose full path is
----------------
I am not familiar with avr-ld internal, but it will implicitly:

1. Use `__vectors` as the entry;
2. Use `$AVR-LIBC/lib/ldscripts/$FamilyName.xn` as the linker script;
 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126192/new/

https://reviews.llvm.org/D126192