[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

Sat May 21 21:53:56 PDT 2022

paulaltin added a comment.

Thanks for preparing this revision @salman-javed-nz!

Do you think it could be worth adding a few more test cases to cover this? It turned out that this issue wasn't actually specific to multi-line macros (see this comment <https://github.com/llvm/llvm-project/issues/55134#issuecomment-1112522063>), so if the test case on line 96 was passing then it must not be fully/correctly testing NOLINT for single-line macros. I guess the only way to do this would be to add more checks to the nolint.cpp file, but I realise that's not a trivial change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126138/new/

https://reviews.llvm.org/D126138