[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 21 21:03:57 PDT 2022


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:341
+  MCInst TmpInst;
+  TmpInst.setOpcode(X86::INT3);
+  AsmPrinter::emitBasicBlockEnd(MBB);
----------------
craig.topper wrote:
> Why is TmpInst created unconditionally and not in the if?
Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126137/new/

https://reviews.llvm.org/D126137



More information about the cfe-commits mailing list