[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 20 11:51:22 PDT 2022
efriedma added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9977
+ StoreInst *Store = Builder.CreateAlignedStore(
+ Val, Ptr, getContext().getTypeAlignInChars(E->getType()));
+ return Store;
----------------
I think I'd prefer just "CharUnits::One()", rather than getTypeAlignInChars(); given the lack of documentation, it's not clear if the offset is required to be properly aligned.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126023/new/
https://reviews.llvm.org/D126023
More information about the cfe-commits
mailing list