[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 20 10:29:57 PDT 2022


rnk added a comment.

I was unable to find any documentation for the meaning of AArch64 addrspace(256), and I wasn't able to figure it out after studying the code in llvm/lib/Target/AArch64 for ten minutes or so. The change seems fine, but please add some documentation as a follow-up. X86 has some of its address spaces documented here, not that this is the best place:
https://llvm.org/docs/CodeGenerator.html#x86-address-spaces-supported


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126023/new/

https://reviews.llvm.org/D126023



More information about the cfe-commits mailing list