[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

[Balázs Benics via Phabricator via cfe-commits]

steakhal created this revision.
steakhal added reviewers: aaron.ballman, lattner.
Herald added subscribers: ayermolo, jdoerfert, martong, mgrang, hiraditya.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: jhenderson.
Herald added a reviewer: Szelethus.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
steakhal requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, yota9, MaskRay.
Herald added projects: clang, LLVM.

One could reuse this functor instead of rolling out your own version.
There were a couple other cases where the code was similar, but not
quite the same, such as it might have an assertion in the lambda or other
constructs. Thus, I've not touched any of those, as it might change the
behavior in some way.

As per https://discourse.llvm.org/t/submitting-simple-nfc-patches/62640/3?u=steakhal
Chris Lattner

> LLVM intentionally has a “yes, you can apply common sense judgement to
> things” policy when it comes to code review. If you are doing mechanical
> patches (e.g. adopting less_first) that apply to the entire monorepo,
> then you don’t need everyone in the monorepo to sign off on it. Having
> some +1 validation from someone is useful, but you don’t need everyone
> whose code you touch to weigh in.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126068

Files:
  bolt/lib/Passes/LongJmp.cpp
  clang/lib/Frontend/FrontendAction.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/Sema/SemaStmtAsm.cpp
  clang/lib/StaticAnalyzer/Frontend/AnalyzerHelpFlags.cpp
  clang/unittests/Introspection/IntrospectionTest.cpp
  llvm/include/llvm/ExecutionEngine/Orc/Core.h
  llvm/lib/IR/Attributes.cpp
  llvm/lib/ObjCopy/MachO/MachOWriter.cpp
  llvm/tools/dsymutil/DebugMap.cpp
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126068.430965.patch
Type: text/x-patch
Size: 9260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220520/9edee2dd/attachment.bin>