[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D125970#3527624 <https://reviews.llvm.org/D125970#3527624>, @aaron.ballman wrote:

>> The primary application is for more rapid debugging of the amdgpu backend by permuting a C or C++ test file instead of manually updating an IR file.
>
> Given that this is adding a calling convention, which has significant impacts on our type system: is this use case important enough to steal a bit for this CC? This sounds *super* special case to me, but maybe it's a common need?

Btw, I'd appreciate if you gave code reviewers more than one day to review a change to the type system before landing -- I'm in WG14 meetings all week, so I don't have much time to do a thorough review of something like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125970/new/

https://reviews.llvm.org/D125970