[PATCH] D125961: [clang-format] Don't break lines after pragma region

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 20 05:10:57 PDT 2022


curdeius added a comment.

In D125961#3527452 <https://reviews.llvm.org/D125961#3527452>, @thieta wrote:

> In D125961#3527447 <https://reviews.llvm.org/D125961#3527447>, @curdeius wrote:
>
>> Thanks for the patch!
>> Could you please add a unit test in unittest/Format/FormatTest.cpp instead of in lit-based test/?
>> Is there a bug report that your patch fixes?
>
> Sure - I didn't know clang-format used unittests instead.

Yes, non-unit tests serve meeting for the config tests IIRC.

> Maybe there should be some documentation around this for new people used to adding lit tests?

That would certainly help. Feel free to do it if you
Otherwise I'll do it but only later (in ten days or so).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125961/new/

https://reviews.llvm.org/D125961



More information about the cfe-commits mailing list