[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 20 01:19:45 PDT 2022
martong added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:4861
+ ToUsingPack->setLexicalDeclContext(LexicalDC);
+ LexicalDC->addDeclInternal(ToUsingPack);
+
----------------
Why don't we use `addDeclToContexts`?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:925
+ classTemplateSpecializationDecl(hasDescendant(usingPackDecl())))))));
+}
+
----------------
Should we also check if the DeclContext and the Extensions are properly set?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125986/new/
https://reviews.llvm.org/D125986
More information about the cfe-commits
mailing list