[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

Thu May 19 13:20:19 PDT 2022

yaxunl added a comment.

In D125970#3526053 <https://reviews.llvm.org/D125970#3526053>, @JonChesterfield wrote:

> In D125970#3525985 <https://reviews.llvm.org/D125970#3525985>, @yaxunl wrote:
>
>> need a codegen test to make sure amdgpu_kernel ABI is used in C/C++ for functions with this attribute
>
> We've already got tests that check the amdgpu_kernel calling conv is lowered correctly. This change only adds it to clang, so checking the IR seems sufficient. I can copy/paste/mod that test case if you like, but it doesn't give any extra coverage that I can see

we only need an IR test, e.g. check struct type kernel arg is using byref.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125970/new/

https://reviews.llvm.org/D125970