[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin
Anders Waldenborg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 19 13:16:37 PDT 2022
wanders added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762
// reject options that shouldn't be supported in bitcode
// also reject kernel/kext
static const constexpr unsigned kBitcodeOptionIgnorelist[] = {
----------------
This comment and variable name are not as accurate any longer. Maybe moving it inside `if (RawTriple.isOSDarwin())` makes it clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125974/new/
https://reviews.llvm.org/D125974
More information about the cfe-commits
mailing list