[libunwind] a5f3625 - [libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 07:58:27 PDT 2022


Author: Louis Dionne
Date: 2022-05-19T10:58:13-04:00
New Revision: a5f36259a20533d9c970ab6a5faab7cf341ca1c9

URL: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9
DIFF: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9.diff

LOG: [libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests

The _LIBUNWIND_HAS_NO_THREADS macro is only picked up by libunwind
inside its sources, so it is only required when it builds. It doesn't
need to be defined when running the tests.

Added: 
    

Modified: 
    libunwind/test/configs/llvm-libunwind-merged.cfg.in
    libunwind/test/configs/llvm-libunwind-shared.cfg.in
    libunwind/test/configs/llvm-libunwind-static.cfg.in

Removed: 
    


################################################################################
diff  --git a/libunwind/test/configs/llvm-libunwind-merged.cfg.in b/libunwind/test/configs/llvm-libunwind-merged.cfg.in
index 19808a173ad8c..76b572c4cdbf7 100644
--- a/libunwind/test/configs/llvm-libunwind-merged.cfg.in
+++ b/libunwind/test/configs/llvm-libunwind-merged.cfg.in
@@ -25,7 +25,6 @@ if @LIBUNWIND_USES_ARM_EHABI@:
     config.available_features.add('libunwind-arm-ehabi')
 
 if not @LIBUNWIND_ENABLE_THREADS@:
-    compile_flags.append('-D_LIBUNWIND_HAS_NO_THREADS')
     config.available_features.add('libunwind-no-threads')
 
 if @LIBUNWIND_ENABLE_CET@:

diff  --git a/libunwind/test/configs/llvm-libunwind-shared.cfg.in b/libunwind/test/configs/llvm-libunwind-shared.cfg.in
index c0a3e4d922be7..11c9faedf0b84 100644
--- a/libunwind/test/configs/llvm-libunwind-shared.cfg.in
+++ b/libunwind/test/configs/llvm-libunwind-shared.cfg.in
@@ -28,7 +28,6 @@ if @LIBUNWIND_USES_ARM_EHABI@:
     config.available_features.add('libunwind-arm-ehabi')
 
 if not @LIBUNWIND_ENABLE_THREADS@:
-    compile_flags.append('-D_LIBUNWIND_HAS_NO_THREADS')
     config.available_features.add('libunwind-no-threads')
 
 if @LIBUNWIND_ENABLE_CET@:

diff  --git a/libunwind/test/configs/llvm-libunwind-static.cfg.in b/libunwind/test/configs/llvm-libunwind-static.cfg.in
index 0bb4207307177..ce5a6c82caa06 100644
--- a/libunwind/test/configs/llvm-libunwind-static.cfg.in
+++ b/libunwind/test/configs/llvm-libunwind-static.cfg.in
@@ -29,7 +29,6 @@ if @LIBUNWIND_USES_ARM_EHABI@:
     config.available_features.add('libunwind-arm-ehabi')
 
 if not @LIBUNWIND_ENABLE_THREADS@:
-    compile_flags.append('-D_LIBUNWIND_HAS_NO_THREADS')
     config.available_features.add('libunwind-no-threads')
 else:
     link_flags.append('-lpthread')


        


More information about the cfe-commits mailing list