[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel added a comment.

Thanks! Looks good overall, just the one question about loops.



================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598
+      MergedEnv.makeOr(
+          MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal1),
+          MergedEnv.makeAnd(Env2.getFlowConditionToken(), *HasValueVal2)));
----------------
What's the plan for loops? This will increase the size of the constraint on every iteration, preventing termination.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125931/new/

https://reviews.llvm.org/D125931