[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

In D125892#3524453 <https://reviews.llvm.org/D125892#3524453>, @steakhal wrote:

> Now I see, the summary confused me.
>
>> This includes the refactoring of the common assumle*Dual logic into the
>> function template assumeDualImpl.
>
> I felt like this is a refactoring change, but it was not. It's about fixing the behavior by using the `cloneAsPosteriorlyOverconstrained()`.
> Please reword the summary.

Ok, done.



================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h:42-46
+  ProgramStateRef assumeInclusiveRangeInternal(ProgramStateRef State,
+                                               NonLoc Value,
+                                               const llvm::APSInt &From,
+                                               const llvm::APSInt &To,
+                                               bool InRange) override;
----------------
steakhal wrote:
> Why is this in the `public:` section, if the name of it suggests its a detail?
Good point. I moved them under `protected:`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125892/new/

https://reviews.llvm.org/D125892