[PATCH] D125925: Add an option to fill container for ref

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Can you also update the remote-index protos & marshalling logic in:

- clang-tools-extra/clangd/index/remote/Index.proto
- clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp



================
Comment at: clang-tools-extra/clangd/index/Index.h:75
   llvm::Optional<uint32_t> Limit;
+  /// If set, populates the SymbolID for the container of the reference.
+  bool WantContainer;
----------------

let's drop `the SymbolID for` also mention `Index implementations may chose to populate containers no matter what.`


================
Comment at: clang-tools-extra/clangd/index/Index.h:76
+  /// If set, populates the SymbolID for the container of the reference.
+  bool WantContainer;
 };
----------------
can you default this to false?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125925/new/

https://reviews.llvm.org/D125925