[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

Wed May 18 09:46:53 PDT 2022

aaron.ballman added a comment.

In D125259#3522198 <https://reviews.llvm.org/D125259#3522198>, @aaron.ballman wrote:

> In D125259#3520118 <https://reviews.llvm.org/D125259#3520118>, @aaron.ballman wrote:
>
>> In D125259#3519947 <https://reviews.llvm.org/D125259#3519947>, @aaron.ballman wrote:
>>
>>> Oh wow, good catch! I'll correct this.
>>
>> Oof, the plot thickens... the diagnostic is correct for some types, but is incorrect for others: https://godbolt.org/z/fahzx53W6. I also discovered a parsing issue in C++ where we get confused by elaborated type specifiers: https://godbolt.org/z/1ejxqd9ss.
>
> https://reviews.llvm.org/D125882 addresses the diagnostic behavior for the unreachable warning.

I landed that fix in 47b8424a533d5c02fd8b3517047cf93e533f00d0 <https://reviews.llvm.org/rG47b8424a533d5c02fd8b3517047cf93e533f00d0>, thank you for pointing it out @aeubanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125259/new/

https://reviews.llvm.org/D125259