[PATCH] D115232: [clangd] Indexing of standard library

Wed May 18 08:42:39 PDT 2022

thakis added a comment.

In D115232#3522571 <https://reviews.llvm.org/D115232#3522571>, @sammccall wrote:

> In D115232#3522514 <https://reviews.llvm.org/D115232#3522514>, @thakis wrote:
>
>> In D115232#3520461 <https://reviews.llvm.org/D115232#3520461>, @sammccall wrote:
>>
>>> Hmm, the test keeps crashing on the GN bot: http://45.33.8.238/win/58316/step_9.txt
>>> Unfortunately the stacktrace is not symbolized, and I'm not seeing this elsewhere (e.g. premerge bot).
>>>
>>> @thakis, any idea why unittests no longer manage to symbolize stack traces on crash on the windows bot? I believe this used to work...
>>
>> I do not know. Maybe related to the "run many unit tests in a single process" lit change from a month ago?
>
> I suspected that, and verified locally that:
>
> - llvm-symbolizer on PATH still works
> - LLVM_SYMBOLIZER_PATH env variable didn't work, but I fixed it in 1236b66a98197109ed40141329d6056dfbe25967 <https://reviews.llvm.org/rG1236b66a98197109ed40141329d6056dfbe25967> along with this reland, still no dice.

(My bot neither has llvm-symbolizer on path, nor sets LLVM_SYMBOLIZER_PATH fwiw.)

>> Anyways, looks like this relanded and broke tests yet again. Maybe find a win box before relanding the next time?
>
> I found one, but the test doesn't crash (nor on the premerge bots).
>
> I'll revert again, but I have no idea how to proceed. Only this bot and `llvm-avr-linux` show the failure, and neither of them have a working symbolizer.

I wouldn't be super surprised if this is related to windows and delayed template parsing. I haven't found any bots on llvm's official waterfall that run ClangdTests.exe – maybe that's why there aren't more bots finding this?

I'd recommend building and running the test on a win box and see if it repros locally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115232/new/

https://reviews.llvm.org/D115232