[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

Wed May 18 08:25:26 PDT 2022

martong marked an inline comment as done.
martong added a comment.

In D125871#3521967 <https://reviews.llvm.org/D125871#3521967>, @steakhal wrote:

> Could you please give a few examples of these FPs for the record?

Out of thin air I could come up with the following one below. Seems like `try` is not handled, but it is not attached to the fact of being non full-path. Maybe I was in too much rush, perhaps we should leave this checker here.
F23106602: image.png <https://reviews.llvm.org/F23106602>

Besides, there is an annoying true positive which should be suppressed IMHO.
F23106640: image.png <https://reviews.llvm.org/F23106640>

================
Comment at: clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:53-54
-
-  if (Eng.hasWorkRemaining())
-    return;
-
----------------
steakhal wrote:
> I thought this check guards this checker to be meaningful. @martong
To be honest, I missed this. So, at least the checker does not report, when the budge is out, i.e. when we definitely know for sure that we could not explore the whole graph. 

On the other hand, even if there is no work remaining for the engine, we still cannot be sure that all theoretical program paths have been covered can we?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125871/new/

https://reviews.llvm.org/D125871