[PATCH] D125604: [FileCheck] Catch missspelled directives.
Dave Green via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 18 06:52:25 PDT 2022
dmgreen added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688
+; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h
+; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h
+; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]]
+; TODO-CVT-DAG: xtn [[I16:v[0-9]+]].4h, [[LOF32]]
+; TODO-CVT-DAG: fcvtzs [[HIF32:v[0-9]+\.4s]], [[HI]]
+; TODO-CVT-DAG: xtn2 [[I16]].8h, [[HIF32]]
+; TODO-NEXT: ret
----------------
kosarev wrote:
> @az
These lines should be removed. The were accidentally left in as the file was update_llc_test_check'd
================
Comment at: llvm/test/CodeGen/Thumb2/thumb2-execute-only-prologue.ll:13
; CHECK: .LCPI0_0:
-; CHECK_NEXT: long 4294963196
+; TODO-NEXT: long 4294963196
+
----------------
kosarev wrote:
> @keith.walker.arm
I think `; CHECK-NEXT: .long 4294965696` should be OK. That looks like it would match up with the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125604/new/
https://reviews.llvm.org/D125604
More information about the cfe-commits
mailing list