[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37
 
-#include <mysystemlib.h> // FIXME: We should have no warning into system headers.
-// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning: inclusion of deprecated C++ header 'assert.h'; consider using 'cassert' instead [modernize-deprecated-headers]
+#include <mysystemlib.h> // no-warning: Don't warn into system headers.
 
----------------
LegalizeAdulthood wrote:
> Where is this file?  I can't find it in my tree.
> 
> ```
> D:\legalize\llvm\llvm-project\clang-tools-extra
> > dir/s/b mysystemlib.h
> File Not Found
> ```
> 
> Does this patch depend on some other unsubmitted patch?
D125209 should have included this file at `clang-tools-extra/test/clang-tidy/checkers/Inputs/modernize-deprecated-headers/mysystemlib.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125770/new/

https://reviews.llvm.org/D125770