[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

Tue May 17 16:09:15 PDT 2022

zukatsinadze added a comment.

In D124244#3493307 <https://reviews.llvm.org/D124244#3493307>, @martong wrote:

>> The patch adds two new checkers.
>
> I don't see any technical dependencies between the two, so, please split it into two independent patches.

StoreToImmutable does not depend on the modeling checker, but I am using the BugType pointer from StoreToImmutable in the modeling checker for Note diagnostics. 
Should it still be split and just not merge the second patch until the first one is committed?

In D124244#3493310 <https://reviews.llvm.org/D124244#3493310>, @martong wrote:

> Also, could you please update the `Static Analyzer` section of `clang/docs/ReleaseNotes.rst` with the new checkers and their description?

Sorry, I missed this comment. I will add release notes in the next round.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124244/new/

https://reviews.llvm.org/D124244