[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa<Ts...>

Tue May 17 10:18:11 PDT 2022

steakhal added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Checkers/ObjCAtSyncChecker.cpp:44
   // Uninitialized value used for the mutex?
-  if (V.getAs<UndefinedVal>()) {
+  if (V.isa<UndefinedVal>()) {
     if (ExplodedNode *N = C.generateErrorNode()) {
----------------
xazax.hun wrote:
> Is there a difference between `isa<UndefinedVal>` vs `IsUndef`? I think we should standardize on one of them (or potentially remove `IsUndef` and the like?
Yea, they are the same. I'm not sure which to pick though.
I still like the terser member function style. I'll replace this occurrence and similars.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125749/new/

https://reviews.llvm.org/D125749