[PATCH] D125705: [OpenMP] Don't build the offloading driver without a source input

Tue May 17 09:09:30 PDT 2022

yaxunl added a comment.

In D125705#3519605 <https://reviews.llvm.org/D125705#3519605>, @jhuber6 wrote:

> In D125705#3519570 <https://reviews.llvm.org/D125705#3519570>, @yaxunl wrote:
>
>> HIP toolchain allows clang driver to compile bundled bitcode or assembly for mixed host/device compilation or device-only multi-GPU compilation.
>>
>> e.g.
>>
>> clang --offload-arch=gfx906 --offload-arch=gfx908 a.bc b.s
>>
>> Can you add a test to make sure this does not break HIP toolchain? Thanks.
>
> This only changes the new driver, which doesn't support HIP right now anyway. This should be captured by some existing tests but I could try to dig them up

If it is only for the new driver that is fine. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125705/new/

https://reviews.llvm.org/D125705