[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 08:14:50 PDT 2022


tstellar added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156
     Prefixes.push_back("/opt/rh/devtoolset-10/root/usr");
     Prefixes.push_back("/opt/rh/devtoolset-9/root/usr");
     Prefixes.push_back("/opt/rh/devtoolset-8/root/usr");
----------------
MaskRay wrote:
> The detection is wasted every Linux user (even if they don't use RedHat/Fedora). Some may need to be refactored to detect `/opt/rh` first. Some ancient devtoolset-* may be deleted now.
@kamaub Are you planning to address these comments in a follow up change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125499/new/

https://reviews.llvm.org/D125499



More information about the cfe-commits mailing list